Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix:withCatsがフィルタされていない問題を修正 #323

Merged
merged 9 commits into from
Aug 14, 2024

Conversation

penginn-net
Copy link
Collaborator

What

Fix:withCatsがフィルタされていない問題を修正

Why

Fix #300

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Update CHANGELOG_CHERRYPICK.md
  • (If possible) Add tests

Copy link
Contributor

github-actions bot commented Aug 14, 2024

이 PR에 의한 api.json 차이

차이점은 여기에서 볼 수 있음

Get diff files from Workflow Page

Copy link

codecov bot commented Aug 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Project coverage is 38.54%. Comparing base (040a8a8) to head (ecfff0f).
Report is 26 commits behind head on develop.

Files Patch % Lines
.../src/server/api/stream/channels/global-timeline.ts 0.00% 3 Missing ⚠️
...nd/src/server/api/stream/channels/home-timeline.ts 0.00% 3 Missing ⚠️
.../src/server/api/stream/channels/hybrid-timeline.ts 0.00% 3 Missing ⚠️
...d/src/server/api/stream/channels/local-timeline.ts 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop     #323       +/-   ##
============================================
- Coverage    62.70%   38.54%   -24.16%     
============================================
  Files          876     1654      +778     
  Lines       105664   215342   +109678     
  Branches      2707     3682      +975     
============================================
+ Hits         66255    83009    +16754     
- Misses       39346   131721    +92375     
- Partials        63      612      +549     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Aug 14, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
91.9% Duplication on New Code (required ≤ 3%)
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@penginn-net penginn-net merged commit fda6853 into yojo-art:develop Aug 14, 2024
23 of 27 checks passed
@kozakura913 kozakura913 added this to the yojo0.5.2 milestone Aug 14, 2024
@kozakura913 kozakura913 mentioned this pull request Aug 14, 2024
@penginn-net penginn-net deleted the fix-withcats branch August 15, 2024 04:51
penginn-net added a commit to penginn-net/cherrypick that referenced this pull request Aug 18, 2024
kozakura913 pushed a commit to kozakura913/yojo-art that referenced this pull request Aug 29, 2024
* Fix:withCatsがフィルタされていない問題を修正 (yojo-art#323)

* del:test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ネコ耳付きTL設定でWebsocketから取得したネコ耳なしが含まれる
2 participants